Skip to content

Conversation

@marcusmoore
Copy link
Collaborator

THIS PR DELETES DATA FROM THE ACTIVITY LOG

@snipe @uberbrady the query in the migration seems simple enough but please try to think of any ways it could go wrong and delete extra data.


This PR stops the reporting of ReportTemplate creates, updates, and deletes to the activity log and purges existing activity log records.

For reference: reporting was originally included in #15714


Fixes #16417

@what-the-diff
Copy link

what-the-diff bot commented Mar 4, 2025

PR Summary

  • Removal of Activity Logging
    Previous versions of our software kept a detailed log of the creation, updating, and deletion actions pertaining to the Report Template model. These logs have now been removed to streamline our processes and maximize efficiency.

  • Introduction of a New Migration
    A new migration process has been introduced to clean any previous logs related to the Report Template model's activity. This process will retrospectively clean up our system and improve storage efficiency.

  • Deletion of Redundant Tests
    As we've removed the logging functionalities associated with the Report Template model, any tests that were specifically designed to examine these functionalities are no longer required. As such, the 'ReportTemplateActionLogTransformerTest' and 'ReportTemplateActivityLoggingTest' have been deleted, reducing the clutter and complexity of our testing procedures.

@snipe snipe merged commit fae79a9 into grokability:develop Mar 4, 2025
8 of 9 checks passed
@snipe
Copy link
Member

snipe commented Mar 4, 2025

Looks good, ty!

@marcusmoore marcusmoore deleted the chore/custom-report-template-activity-log-removal branch March 10, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants